Refactor, crate updates, and printing measurements#1
Open
jakecorrenti wants to merge 3 commits intovirtee:mainfrom
Open
Refactor, crate updates, and printing measurements#1jakecorrenti wants to merge 3 commits intovirtee:mainfrom
jakecorrenti wants to merge 3 commits intovirtee:mainfrom
Conversation
Refactor how the kernel name is parsed to avoid manual string manipulation. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
`cargo audit` reported a vulnerability in the `time` crate. Update the dependency to a version with the necessary fix. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
Like the nitro-cli tool, print the measurements when the EIF file is successfully built. This allows users to use those PCR values for reference values during attestation. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
jakecorrenti
force-pushed
the
add-measurements
branch
from
9b15a1a to
853d068
Compare
tylerfanelli
requested changes
Mar 12, 2026
|
|
||
| build.write_to(&mut output); | ||
| let measurements = build.write_to(&mut output); | ||
| println!("{:#?}", measurements); |
Member
There was a problem hiding this comment.
I would suggest the printing of measurements to be optional. Perhaps we should hide this behind a flag or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor retrieving the kernel name to avoid manual string manipulation.
Update the
timecrate to a version including a CVE fix.Print the measurements when building the EIF file is successful like the nitro-cli tool. This helps users use these measurements for attestation reference values.