allow pod controller config overrides #1309
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alec-rabold
force-pushed
the
feature/pod-controller-config-overrides
branch
from
b7b4410 to
7a5eacc
Compare
pires
force-pushed
the
feature/pod-controller-config-overrides
branch
from
c387bd7 to
4dd3606
Compare
pires
added
enhancement
help wanted
go
Member
|
This breaks code badly :-( |
pires
previously requested changes
Oct 30, 2025
Member
pires
left a comment
pires
left a comment
There was a problem hiding this comment.
This breaks code badly :-( Please, fix.
Member
|
@alec-rabold did you end up using these changes in your provider? It seems the changes are incomplete and it would be great to consider this for inclusion soon 🙏🏻 |
Author
hey @pires sorry for the delay, we ended up not using this specific config but I do think it would still be beneficial; I'll spend some time today fixing this up to pass the unit/e2e tests |
alec-rabold
force-pushed
the
feature/pod-controller-config-overrides
branch
from
4dd3606 to
ede3100
Compare
Author
|
updated! (and verified the unit tests and e2e suite passes) I don't love the nested options style I've added, but should work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding pod controller config options
Current use-case is for
SyncPodsFromKubernetesRateLimiter+SyncPodsFromKubernetesShouldRetryFunc-- specifically to infinitely retry for certain errors instead of stopping at 20 attempts (e.g. similar toImagePullBackoff)