-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add Pull Request Template #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SaarthakMaini
wants to merge
2
commits into
virtual-tech-school:main
Choose a base branch
from
SaarthakMaini:add-pull-request-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| ### All Submissions: | ||
|
|
||
| - [ ] Have you followed the guidelines stated in [CONTRIBUTING.md](https://github.com/virtual-tech-school/frytheweb/blob/main/CONTRIBUTING.md) file? | ||
| - [ ] Have you checked to ensure there aren't any other open [Pull Requests](https://github.com/virtual-tech-school/frytheweb/pulls ) for the desired changed? | ||
|
|
||
| <!-- You can erase any parts of this template not applicable to your Pull Request. --> | ||
|
|
||
| ### Type of change | ||
|
|
||
| Please delete options that are not relevant. | ||
|
|
||
| - [ ] Bug fix (non-breaking change which fixes an issue) | ||
| - [ ] New feature (non-breaking change which adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
| - [ ] This change requires a documentation update | ||
|
|
||
|
|
||
| ### New Feature Submission: | ||
|
|
||
| - [ ] Does your submission pass the tests? | ||
| - [ ] Have you linted your code locally prior to submission? | ||
|
|
||
| ### Changes To Core Features: | ||
SaarthakMaini marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| - [ ] Have you added an explanation of what your changes do and why you'd like us to include them? | ||
| - [ ] Have you written new tests for your core changes, as applicable? | ||
| - [ ] Have you successfully ran tests with your changes locally? | ||
|
|
||
| ### **After** these steps, you're ready to open a pull request. | ||
|
|
||
| a. Give a descriptive title to your PR. | ||
|
|
||
| b. Describe your changes. | ||
|
|
||
| c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such). | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.