Skip to content

fix: updates pydeck pyproject.toml to include dynamic field #10048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lanceypantsy wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −0
Open

fix: updates pydeck pyproject.toml to include dynamic field #10048

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9acd72
fix: updates pydeck pyproject.toml to include dynamic field
Lanceypantsy Feb 26, 2026
ffe4c98
Merge branch 'master' into pydeck-update-dynamic-pyproject
chrisgervang Feb 27, 2026
79816b7
Merge branch 'master' into pydeck-update-dynamic-pyproject
chrisgervang Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bindings/pydeck/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
name = "pydeck"
version = "0.9.1"
requires-python = ">=3.8"
dynamic = ["readme", "license", "authors", "keywords", "classifiers", "dependencies", "optional-dependencies"]
Copy link

@cursor cursor bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing description in dynamic field list

Medium Severity

The dynamic list is missing "description", even though setup.py defines description="Widget for deck.gl maps". Since description is neither statically declared in [project] nor listed in dynamic, modern setuptools will silently ignore it — the exact same class of bug this PR aims to fix for readme. The package metadata will have no description.

Fix in Cursor Fix in Web

Copy link
Collaborator

@chrisgervang chrisgervang Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lanceypantsy could you decide if this should be addressed?

Copy link

@cursor cursor bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing urls in dynamic field list

Low Severity

The dynamic list is missing "urls", even though setup.py defines url="https://github.com/visgl/deck.gl/tree/master/bindings/pydeck". The url parameter in setup() maps to the urls metadata field in PEP 621. Without declaring it in dynamic, modern setuptools will silently drop the homepage URL from the package metadata, so PyPI will show no project URL.

Fix in Cursor Fix in Web


[build-system]
requires = [
Expand Down