Open
Conversation
- .nvmrc: 20.19.0 → 22.14.0 - package.json engines: >=20 → >=22 - website/package.json engines: >=20 → >=22 - CONTRIBUTING.md: update documented requirement Node 22 is the current LTS release. https://claude.ai/code/session_016oyFSyGm7hYU1e1KDXqjnW
chrisgervang
changed the title
page.waitFor() was removed in Puppeteer 19. Replace all three call sites in node-examples.js with a local sleep helper using setTimeout. https://claude.ai/code/session_016oyFSyGm7hYU1e1KDXqjnW
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Node.js 22 added navigator as a getter-only Web-compatible global. Direct assignment throws TypeError. Use Object.defineProperty to override it with the JSDOM value instead. https://claude.ai/code/session_016oyFSyGm7hYU1e1KDXqjnW
Node.js 21+ ships navigator as a built-in global. The manual assignment from JSDOM was originally needed when Node lacked it, and nothing in the Node test suite actually requires the JSDOM navigator value. https://claude.ai/code/session_016oyFSyGm7hYU1e1KDXqjnW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 20 reaches EOL in April 2026; this moves to Node 22 LTS.
Changes:
Note
Medium Risk
Moderate risk because it raises the minimum runtime/tooling version across the repo, which can break local dev/CI environments still on Node 20. Test code changes are small but touch headless browser timing and Node/JSDOM globals.
Overview
Updates the repo’s required Node version to Node 22 by bumping
.nvmrc,engines.nodein both root andwebsite/package.json, and the Node requirement noted inCONTRIBUTING.md.Adjusts Node-based tests for compatibility: replaces deprecated Puppeteer
page.waitForusage with an explicitsleephelper intest/node-examples.js, and removes the JSDOMnavigatorglobal assignment intest/node.ts.Written by Cursor Bugbot for commit 2c1db97. This will update automatically on new commits. Configure here.