Skip to content

fix(jupyter-widget): prevent erroneous CJS output#10053

Closed
chrisgervang wants to merge 1 commit intomasterfrom
chr/jupyter-cjs-output
Closed

fix(jupyter-widget): prevent erroneous CJS output#10053
chrisgervang wants to merge 1 commit intomasterfrom
chr/jupyter-cjs-output

Conversation

@chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Feb 27, 2026

Summary

  • Bump @vis.gl/dev-tools to 1.0.2 which fixes a bug where the CJS fallback path used ./dist.index.cjs instead of ./dist/index.cjs
  • Add exports field to jupyter-widget to prevent it from hitting the buggy fallback code path
  • Add gitignore for erroneous dist.index.cjs files as a defensive measure

Background

After a clean build, modules/jupyter-widget/dist.index.cjs and .map files were being generated at the module root (not inside dist/). This was caused by a typo in @vis.gl/dev-tools@1.0.1 where modules without an exports field would get CJS files written to ./dist.index.cjs instead of ./dist/index.cjs.

Test plan

  • Verify yarn build no longer produces modules/jupyter-widget/dist.index.cjs

🤖 Generated with Claude Code


Note

Low Risk
Low risk dependency bump limited to dev tooling; primary risk is build/test behavior changes from the updated dev-tools package.

Overview
Updates the dev dependency @vis.gl/dev-tools from 1.0.1 to 1.0.2 (with corresponding yarn.lock updates), refreshing the repository’s build/test tooling dependency without changing application/runtime code.

Written by Cursor Bugbot for commit 32f462a. This will update automatically on new commits. Configure here.

@chrisgervang chrisgervang force-pushed the chr/jupyter-cjs-output branch from a126a7d to 47ab05d Compare February 27, 2026 17:09
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@chrisgervang chrisgervang force-pushed the chr/jupyter-cjs-output branch from 47ab05d to b743f87 Compare February 27, 2026 17:31
Fixes erroneous CJS output path bug.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant