fix(jupyter-widget): prevent erroneous CJS output#10053
Closed
chrisgervang wants to merge 1 commit intomasterfrom
Closed
fix(jupyter-widget): prevent erroneous CJS output#10053chrisgervang wants to merge 1 commit intomasterfrom
chrisgervang wants to merge 1 commit intomasterfrom
Conversation
420254a to
f1b9356
Compare
f1b9356 to
a126a7d
Compare
a126a7d to
47ab05d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
47ab05d to
b743f87
Compare
Fixes erroneous CJS output path bug. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b743f87 to
32f462a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vis.gl/dev-toolsto 1.0.2 which fixes a bug where the CJS fallback path used./dist.index.cjsinstead of./dist/index.cjsexportsfield to jupyter-widget to prevent it from hitting the buggy fallback code pathdist.index.cjsfiles as a defensive measureBackground
After a clean build,
modules/jupyter-widget/dist.index.cjsand.mapfiles were being generated at the module root (not insidedist/). This was caused by a typo in@vis.gl/dev-tools@1.0.1where modules without anexportsfield would get CJS files written to./dist.index.cjsinstead of./dist/index.cjs.Test plan
yarn buildno longer producesmodules/jupyter-widget/dist.index.cjs🤖 Generated with Claude Code
Note
Low Risk
Low risk dependency bump limited to dev tooling; primary risk is build/test behavior changes from the updated dev-tools package.
Overview
Updates the dev dependency
@vis.gl/dev-toolsfrom1.0.1to1.0.2(with correspondingyarn.lockupdates), refreshing the repository’s build/test tooling dependency without changing application/runtime code.Written by Cursor Bugbot for commit 32f462a. This will update automatically on new commits. Configure here.