fix(maplibre): luma92 maplibre globe view initialization #9710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which luma PRs changed the canvas resizing logic in luma 9.2? Historically, luma delegated canvas resizing when deck is rendering interleaved. I wonder if interleaved Google maps has any issues in common with Mapbox/maplibre as well |
|
Was this fixed by #9794? |
Yes, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced by #9241
Without fix deck doesn't use globe view
There is still an issue where resizing the window breaks interleaved rendering, but I didn't have bandwidth to address that. There is also the question of whether this is a proper fix, or band-aid for an issue introduced elsewhere, this being a potential suspect. @chrisgervang would you mind taking a look, I'm not that well versed in the React integration.
Change List