calls transform function on constant attribute updates

[blazecus]

Fixes bugs that show up when inputting an accessor as a string instead of a function.

Background

The bug can be seen clearly in this codepen: https://codepen.io/heebeegb/pen/RNWLyXB?editors=0010

Swapping the getIcon accessor to a function will make it work - this pull request calls the transform function for constant attributes as well, fixing the issue.

I changed the typing of "value" to any as the transform function has arbitrary inputs. Strings, numbers, and number arrays are all passed into setConstantValue already, this pipes them into the transform call if it exists.

Change List

• adds a transform call in setConstantValue
• passes in context to setConstantValue for the purposes of the transform call

[blazecus]

@Pessimistress Could you take a look at this PR? Thanks!

[felixpalmer]

Nice, I think I've hit this before. I think it primarily affects IconLayer as having a static icon is a common pattern.

Could you add a test case toattribute.spec.ts? 'standard accessor with transform' could be used as a guide. Run tests with yarn test browser

[blazecus]

@felixpalmer sorry to ping, but could you take a look again?

[felixpalmer]

You need to run yarn lint fix

[blazecus]

You need to run yarn lint fix

My bad, fixed it @felixpalmer

[felixpalmer]

The tests are still failing. Use ‘yarn test browser’ to run locally and try to debug&fix the issue

[blazecus]

@felixpalmer Sorry for the long delay. There was a one line fix that seems to fix a lot of the problems - but there are still 8 "not ok" tests from test browser. That said, test browser seems to fail on the master branch too at the same Scatterplot case (# Jupyter#ScatterplotLayer), so maybe it's a problem with my computer. Would running the tests on github be any different?

[coveralls]

coverage: 91.143% (+0.006%) from 91.137%
when pulling 53e6c42 on blazecus:jb/transform-update
into 8e0d49e on visgl:master.