-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(core): 3D enable MapController using rotatationPivot option #9938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
09a2210
PoC 3D picking
felixpalmer 5e3749b
Augment pickable prop
felixpalmer f59fb30
Tidy
felixpalmer a2e343b
hover support
felixpalmer 97e0ce4
Add elevation label to terrain app
felixpalmer d1c1c76
Rotation pivot point fixed
felixpalmer 85b1fcf
3d enabled rotation pivot point
felixpalmer 068c4cc
prototype rotation pivot
felixpalmer 50743f2
Hook up picking with rotation pivot
felixpalmer 771c3f3
rotation pivot helper
felixpalmer e614ac3
Map3dcontroller
felixpalmer e367799
rotatePivot API
felixpalmer 67914ba
Use planes in demo
felixpalmer 79d2d7f
Shorthand
felixpalmer 9544d5d
Revert vite config
felixpalmer 9eebac1
remove extra override
felixpalmer 90352d0
Unify naming
felixpalmer 11d9dde
Lint
felixpalmer 3b3da3d
Merge branch 'master' into felix/rotate-pivot-3d
felixpalmer 447bdcb
Merge branch 'master' into felix/rotate-pivot-3d
felixpalmer 207e042
tidy
felixpalmer 91b45cb
docs
felixpalmer 549bbdb
Move rotationPivot into MapController
felixpalmer e4d3713
Move pickPosition
felixpalmer c400256
typing
felixpalmer 830e939
Revert test app
felixpalmer ba3ea71
Succinct panByPosition3D
felixpalmer c8b5d6f
Merge branch 'master' into felix/rotate-pivot-3d
felixpalmer e929374
Merge branch 'master' into felix/rotate-pivot-3d
felixpalmer 69ce703
Docs
felixpalmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test app for demo only, will not be commiting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the layers all have a nice mdx pattern of rendering sample data and interactivity - should we consider doing the same per controller? Theres over 5 controllers now.