fix(core): Enable shader/pipeline caching for attached WebGL devices #9971
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -373,6 +373,10 @@ export default class Deck<ViewsT extends ViewOrViews = null> { | |
| const userOnResize = this.props.deviceProps?.onResize; | ||
|
|
||
| deviceOrPromise = webgl2Adapter.attach(props.gl, { | ||
| // Enable shader and pipeline caching for attached devices (matches _createDevice defaults) | ||
| // Without this, interleaved mode (e.g., MapboxOverlay) creates new pipelines every frame | ||
| _cacheShaders: true, | ||
| _cachePipelines: true, | ||
|
Collaborator
There was a problem hiding this comment. Let's put this below the spread in case a user wants to customize their device props. By default
Author
There was a problem hiding this comment. Awesome, thank you so much @chrisgervang! That's a great catch: I've gone ahead and made the required change. I've also gone ahead and manually verified the changes via the Just as a slight note for anyone else wanting to verify the change: I believe that the performance impact scales with scene complexity and interaction frequency. As the
Collaborator
There was a problem hiding this comment. Oh my apologies, I misread your code. Your original code allowed the user to customize the props and now it forces the caching. Let's revert to your original version, please.
Collaborator
There was a problem hiding this comment. Good to hear the example is working!
Author
There was a problem hiding this comment. Hahaha, no worries! Changes reverted and pushed. |
||
| ...this.props.deviceProps, | ||
| onResize: (canvasContext, info) => { | ||
| // Manually sync drawing buffer dimensions (canvas is externally managed) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated caching defaults across device creation paths
Low Severity
The
_cacheShaders: trueand_cachePipelines: truedefault values are now duplicated in two separate locations: thewebgl2Adapter.attach()call and the_createDevice()method. While the comment notes it "matches _createDevice defaults," this relies on manual synchronization. Extracting these defaults to a shared constant would ensure consistent behavior if defaults need to change.Additional Locations (1)
modules/core/src/lib/deck.ts#L865-L867