refactor(encoders): remove archive format, standardize zip#314
Merged
chrisgervang merged 4 commits intomasterfrom Mar 20, 2025
Merged
refactor(encoders): remove archive format, standardize zip#314chrisgervang merged 4 commits intomasterfrom
chrisgervang merged 4 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the encoder modules to remove the legacy 'archive' configuration and standardize ZIP as the only supported archive format, updating both code and documentation.
- Removed the archive option from PNG and JPEG encoders.
- Updated examples and documentation to reflect ZIP encryption.
- Deleted TAR-related utility and builder files.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/core/src/encoders/frame-encoder.ts | Removed archive configuration from PNG and JPEG format settings. |
| examples/website/basic-basemap/app.jsx | Removed archive property from formatConfigs and simplified component structure. |
| examples/website/basic-basemap-mapbox-legacy/app.jsx | Removed archive property and adjusted formatting in usage of DeckGLOverlay. |
| examples/website/basic-basemap-mapbox/app.jsx | Removed archive property and adjusted formatting in usage of DeckGLOverlay. |
| modules/react/src/components/quick-animation.tsx | Updated formatConfigs to remove the archive field in PNG settings. |
| examples/website/camera/app.jsx | Removed archive from PNG settings and updated JPEG configuration in formatConfigs. |
| modules/react/src/components/export-video/export-video-panel-container.tsx | Removed archive property from PNG and JPEG format configurations. |
| docs/api-reference/encoder/jpeg-sequence-encoder.md | Updated encoder description and configuration to reflect ZIP usage instead of TAR. |
| examples/website/terrain/app.jsx | Removed archive property from PNG settings. |
| examples/website/trips/app.tsx | Removed archive property from PNG settings. |
| docs/api-reference/encoder/png-sequence-encoder.md | Updated encoder description and configuration to reflect ZIP usage instead of TAR. |
| modules/core/src/encoders/video/jpeg-sequence-encoder.ts | Removed TAR support; standardized JPEG sequence encoding to use ZIP exclusively. |
| modules/core/src/encoders/video/png-sequence-encoder.ts | Removed TAR support; standardized PNG sequence encoding to use ZIP exclusively. |
| modules/core/src/encoders/tar/* | Deleted unused TAR-related modules (header, tar-builder, tar, utils). |
Comments suppressed due to low confidence (1)
modules/core/src/encoders/video/jpeg-sequence-encoder.ts:24
- [nitpick] Consider standardizing the access of ZipWriter.extensions across encoders. Since PNGSequenceEncoder does not use optional chaining, removing it here could improve consistency.
this.extension = `.${ZipWriter.extensions?.[0]}`;
Pull Request Test Coverage Report for Build 13961936087Details
💛 - Coveralls |
chrisgervang
commented
Mar 19, 2025
Collaborator
Author
|
Tested website examples 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #309
Split out from #285