fix(las): Pass correct params in LAZLoader.readData#3297
Merged
Conversation
felixpalmer
changed the title
ibgreen
reviewed
Feb 21, 2026
| o.maxs = [bounds[0], bounds[2], bounds[4]]; | ||
| o.mins = [bounds[1], bounds[3], bounds[5]]; | ||
|
|
||
| const colorPointFormats = new Set([2, 3]); |
Collaborator
There was a problem hiding this comment.
I think for LAS 1.4 there are more formats.
It might have been nice with constants or a comment, the numbers look a bit mysterious here.
ibgreen
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The point-cloud example was broken with the loaders 4.4 alpha package, see visgl/deck.gl#9972. This PR fixes it
Changes
readDatasignature