feat(textures) Add composite texture loaders#3328
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 930892048f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
modules/textures/src/lib/composite-image/parse-composite-image.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add manifest-driven composite image texture loaders to
@loaders.gl/textures, deprecate the legacy helper APIs, and standardize composite-loader base URL handling aroundLoaderContext.This PR introduces first-class loaders for image textures, texture arrays, cubemaps, and cube arrays, all backed by a shared composite-image parser/resolver. It also adds template-based mip expansion, aligns cubemap face naming with luma.gl conventions, and documents how composite loaders should forward base URLs and subloader lists.
Included Changes
Added new public loaders in
@loaders.gl/textures:ImageTextureLoaderImageTextureArrayLoaderImageTextureCubeLoaderImageTextureCubeArrayLoaderAdded JSON manifest support for:
Added template-based source expansion with strict validation:
mipLevels: "auto"{lod},{index},{face},{direction},{axis},{sign}\{and\}Aligned cubemap manifest keys with luma.gl conventions:
+X,-X,+Y,-Y,+Z,-Zright,left,top,bottom,front,backare still accepted for compatibilityReimplemented legacy
loadImageTexture*helpers on top of the shared composite-image path and marked them@deprecatedStandardized relative URL resolution:
context.baseUrloptions.core.baseUrlonly as a pre-context fallbackUpdated composite member parsing so subresources use:
fetchImageLoaderurl/baseUrlDocumentation
Tests
Added coverage for:
core.baseUrlfallback for in-memory manifestsfetchreuse for member assetsshapeVerification
./node_modules/.bin/tsc -p modules/textures/tsconfig.json --noEmit