Add getCanvasContainer to types #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
requested changes
Feb 15, 2024
Contributor
Author
|
The type was being exposed in the context of using "useControl" from "react-map-gl/maplibre". |
Collaborator
|
I see. Yes, that would be a bug. |
Pessimistress
approved these changes
Dec 19, 2024
chrisgervang
pushed a commit
that referenced
this pull request
Dec 19, 2024
Co-authored-by: Xiaoji Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both MapLibre GL and Mapbox GL have a function 'getCanvasContainer':
I would like to suggest that it be added to the types if possible. The attached is a simple pull request adding this type.
Thanks!