Skip to content

Handle class name change #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pessimistress merged 2 commits into from
Mar 13, 2025
Merged

Handle class name change #2483

Pessimistress merged 2 commits into from
Mar 13, 2025

Conversation

@Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Feb 4, 2025

Closes #2465

  • Consistently handle props.className change in react-mapbox and react-maplibre
  • Test for Marker component className prop change
  • Not changing mapbox-legacy because marker.toggleClassName does not exist in v1

@Pessimistress Pessimistress merged commit d1f61a0 into master Mar 13, 2025
2 checks passed
@Pessimistress Pessimistress deleted the x/classnames branch March 13, 2025 17:25
Pessimistress added a commit that referenced this pull request Mar 28, 2025
@Pessimistress
fix: Handle className prop change (#2483)
dfc9a57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisgervang chrisgervang Awaiting requested review from chrisgervang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Marker className changes do not change when props change

2 participants

@Pessimistress