Fix style loading check on Source layers (#2377) #2493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
approved these changes
Mar 12, 2025
Pessimistress
pushed a commit
that referenced
this pull request
Mar 28, 2025
Co-authored-by: Yovarni Yearwood <[email protected]>
Collaborator
|
Published 8.0.2 |
Collaborator
|
This change is causing a cascade of issues despite various patches. I am unable to reproduce the "style is not done loading" error reported in this thread - the code sandbox has been deleted. I am going to revert the change in the next release. Please help me reproduce your issue so that I can address it properly. |
Pessimistress
added a commit
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2377
Fixed the
Style is not done loadingerror by using a map.isStyleLoaded() function check in place of the primitive values.