fix update-release-branch.sh, links for v8 website #2498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `update-release-branch.sh` script was not updating `.ts` and `.tsx` files and was relying on an old repo structure. Let's make the script work with the new structure and then update links in the docs and examples, replacing outdated versions (e.g., `7.0-release`, `react-mapbox-gl`) with the correct v8 links.
ghost
commented
Mar 11, 2025
| find docs -iname "*.md" -type f -exec sed -i '' -E "s/react-map-gl\/(tree|blob)\/(master|[0-9\.]+-release)/react-map-gl\/tree\/${BRANCH}/g" {} \; | ||
| find examples -maxdepth 0 -iname "*.md" -type f -exec sed -i '' -E "s/react-map-gl\/(tree|blob)\/(master|[0-9\.]+-release)/react-map-gl\/tree\/${BRANCH}/g" {} \; | ||
| find examples/*/src -iname "*.js" -type f -exec sed -i '' -E "s/react-map-gl\/(tree|blob)\/(master|[0-9\.]+-release)/react-map-gl\/tree\/${BRANCH}/g" {} \; | ||
| find docs -mindepth 2 -iname "*.md" -exec perl -i -pe "s/react-map-gl\/(tree|blob)\/(master|[0-9\.]+-release)/react-map-gl\/tree\/${BRANCH}/g" {} \; |
Author
There was a problem hiding this comment.
I'm not super confident in adding -mindepth 2 here. The reason that I added it is that there are a few markdown files under /docs (README.md, upgrade-guide.md, and whats-new.md) that seem to be manually maintained. I’d definitely appreciate any additional thoughts on this.
Collaborator
|
Greatly appreciate your find! I guess the issue came from rearranging the docs directory from v7 to v8... |
Pessimistress
approved these changes
Mar 12, 2025
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update-release-branch.shscript was not updating.tsand.tsxfiles and was relying on an old repo structure. Let's make the script work with the new structure and then update links in the docs and examples, replacing outdated versions (e.g.,7.0-release,react-mapbox-gl) with the correct v8 links.This fixes #2497.