Fix missing python dependencies for pagefind - #20961
Closed
markcmiller86 wants to merge 2 commits into
Closed
Conversation
Contributor
|
By itself, this PR might not fix CI. I think the CI container needs to be updated to have the new python modules installed. |
Member
Author
|
@biagas I have tested this locally and with this invokation of env PYTHONPATH= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our CI on
developis currently broken because the step to produce the manual fails due to pagefind changes.I nelgected to update
bv_python.shto include the new dependencies.I naively thought that updating
requirements.txtwas sufficient. And, if we included OpenSSL in our python builds, I think it would be as simple aspip install -r requirements.txt. That is certainly how RTD does our Sphinx builds.But, not having OpenSSL means we can't rely on
pipto download anything and so all of that needs to be taken care of ahead of time inbv_python.sh.This PR should fix that oversight.
Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
Reminders:
Checklist: