previousSelection returned entire object vs ids#1734
Open
nickchomey wants to merge 3 commits intovisjs:masterfrom
Open
previousSelection returned entire object vs ids#1734nickchomey wants to merge 3 commits intovisjs:masterfrom
nickchomey wants to merge 3 commits intovisjs:masterfrom
Conversation
Previous selection was returning the entire node and edge objects rather than just an array of ids. This fixes it. I only tested it via modifying the vis-network.min.js file directly, but have translated it back to this format. Please check and improve as necessary.
`
value: function (g, A) {
var t = !1,
e = this._selectionAccumulator.commit(),
C = {},
nodes = [],
edges = [];
for (let i = 0; i < e.nodes.previous.length; i++ ){
nodes.push(e.nodes.previous[i].id);
};
for (let i = 0; i < e.edges.previous.length; i++ ){
edges.push(e.edges.previous[i].id);
};
C = {
nodes: nodes,
edges: edges
};
`
|
The following might be neater: Replace lines 18179 - 18182 in vis-network/esnext/esm/vis-network.js : with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1688
previousSelection was returning the entire node and edge objects rather than just an array of ids. This fixes it. I only tested it via modifying the vis-network.min.js file directly, but have translated it back to this format. Please check and improve as necessary. - I am brand new to javascript, so assume there are more efficient ways of extracting the ids.