fix bug horizontal scroll when hiddenDates are present#1934
Open
wesetaca wants to merge 1 commit intovisjs:masterfrom
Open
fix bug horizontal scroll when hiddenDates are present#1934wesetaca wants to merge 1 commit intovisjs:masterfrom
wesetaca wants to merge 1 commit intovisjs:masterfrom
Conversation
…me of onDrag logic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the library - helped me greatly with my angular ERP project, and I thought I should contribute with what I could.
While working with the library I noticed that scrolling with the following config (partial) - the horizontal scroll behaves unpredictably when hitting hiddenDates boundaries or with those boundaries present:
hiddenDates: [
{ start: new Date('2025-08-01T15:00:00.000Z'), end: new Date('2025-08-02T01:00:00.000Z'), repeat: 'daily' },
],
verticalScroll: true,
horizontalScroll: true,
horizontalScrollKey: 'shiftKey',
horizontalScrollInvert: true,
Through a lot of trial and error with console.log, I found the bug was due to the partially developed onMouseWheel (onDrag works fine though so I replicated some of onDrag logic).
This fix was adapted from my monkey-patch of my angular project (I ended up hijacking the mouse wheel back when simultaneous horizontal and vertical Scroll was not supported) - and it is my first time contributing, so excuse me if there's any mistake.
I can attach/email my original fix should you find this adaptation faulty and want the original monkey-patch.