Increase EPSILON to Prevent Overlaps and Overflow#1935
Open
folortin wants to merge 1 commit intovisjs:masterfrom
Open
Increase EPSILON to Prevent Overlaps and Overflow#1935folortin wants to merge 1 commit intovisjs:masterfrom
folortin wants to merge 1 commit intovisjs:masterfrom
Conversation
… overlaps and prevent element overflow during collision detection. The value of EPSILON was changed from 0.001 to 1 to avoid unnecessary overlaps and prevent element overflow during collision detection.
Thomaash
requested changes
Sep 27, 2025
Member
Thomaash
left a comment
Thomaash
left a comment
There was a problem hiding this comment.
Could you provide any evidence and ideally tests for this? The idea was to avoid rounding errors. Increasing it by 3 orders of magnitude doesn't feel right without any concrete data to justify it. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of EPSILON was changed from 0.001 to 1 to avoid unnecessary overlaps and prevent element overflow during collision detection.