fix: rename license files to fix GitHub license detection#2025
Open
gwpl wants to merge 1 commit intovisjs:masterfrom
Open
fix: rename license files to fix GitHub license detection#2025gwpl wants to merge 1 commit intovisjs:masterfrom
gwpl wants to merge 1 commit intovisjs:masterfrom
Conversation
GitHub's licensee detection returns NOASSERTION because LICENSE.md contains only a short markdown wrapper instead of actual license text. Rename license files to match the pattern used by vis-network (which is detected correctly): * LICENSE.md → LICENSE (keeps the wrapper/index file) * LICENSE.Apache-2.0.txt → LICENSE-APACHE-2.0 * LICENSE.MIT.txt → LICENSE-MIT Update references in README.md and package snapshot test accordingly. Closes visjs#2024 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gwpl
force-pushed
the
i2024/fix-license-detection-noassertion
branch
from
027a2ac to
22a5234
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Assistant:
Summary
Fixes #2024
GitHub's licensee detection returns
NOASSERTIONfor this repository becauseLICENSE.mdcontains only a short markdown wrapper with links — not actual license text. This causes the GitHub UI to show "Other" instead of the correct license badge.This PR renames the license files to match the pattern already used by vis-network (which is detected correctly as Apache-2.0):
LICENSE.md→LICENSE(keeps the wrapper/index file)LICENSE.Apache-2.0.txt→LICENSE-APACHE-2.0LICENSE.MIT.txt→LICENSE-MITAll internal references updated (README.md, LICENSE, package snapshot test).
Why this works
licenseerecognizes files namedLICENSE-*as additional license files (docs). WithLICENSE-APACHE-2.0containing the full Apache 2.0 text, it matches against the known SPDX template and detection succeeds.Verification
Before (current state):
After merging, the same command should return
"Apache-2.0", consistent with vis-network:References
Test plan
git mvpreserves file content (no license text changes)gh api repos/visjs/vis-timeline --jq '.license.spdx_id'returns"Apache-2.0"package.json"license": "(Apache-2.0 OR MIT)"unchanged — npm/SPDX detection unaffected(for Github WebUI issue linking: Closes #2024 )
🤖 Generated with Claude Code