feat: option to make timeline items movable but not resizable#2032
Open
feedingaliencat wants to merge 1 commit intovisjs:masterfrom
Open
feat: option to make timeline items movable but not resizable#2032feedingaliencat wants to merge 1 commit intovisjs:masterfrom
feedingaliencat wants to merge 1 commit intovisjs:masterfrom
Conversation
At the moment, the option to control if a timeline item is movable
is the same which controls also its ability to be stretched or shrinked:
editable: { updateTime: boolean; }
This commit wants to split these two operations in two options:
editable: {
updateTime: boolean; // the item can be moved with drag and drop
updateDuration: boolean; // the item can be stretched or shirnked
}
BREAKING CHANGE: The behaviour changes from the previous implementation.
Users who wants to have both the actions need to set `updateDuration: true`
in their codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, the option to control if a timeline item is movable is the same which controls also its ability to be stretched or shrinked:
This commit wants to split these two operations in two options:
BREAKING CHANGE: The behaviour changes from the previous implementation. Users who wants to have both the actions need to set
updateDuration: truein their codebase.Screen recording of the case
updateTime = trueandupdateDuration = false:screen_recording.webm
This PR is a port of @javdome 's #1726 on top the current vis-timeline HEAD.
Fixes #309
Fixes #273