feat: add configurable DuckDB memory limit via DUCKDB_MEMORY_LIMIT env var#43
Open
CarstVaartjes wants to merge 1 commit intovisualfabriq:masterfrom
Open
feat: add configurable DuckDB memory limit via DUCKDB_MEMORY_LIMIT env var#43CarstVaartjes wants to merge 1 commit intovisualfabriq:masterfrom
CarstVaartjes wants to merge 1 commit intovisualfabriq:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DUCKDB_MEMORY_LIMITenvironment variable support to cap DuckDB memory per query connectionDUCKDB_MEMORY_LIMIT=2GB), DuckDB spills to temp storage instead of allocating unbounded memoryContext
DQE reader runs 3 Gunicorn workers in a 7.5GB ECS container. DuckDB's default behavior allocates memory without bounds, causing OOM on large shard aggregations. With
DUCKDB_MEMORY_LIMIT=2GB, each worker caps at 2GB (3×2GB=6GB), leaving headroom for Python/OS.Benchmark (345M-row KCI shard, high-cardinality query)
No performance penalty — bounded memory is actually faster due to less GC pressure.
Changes
parquery/aggregate_duckdb.py: ReadDUCKDB_MEMORY_LIMITenv var, pass asconfigtoduckdb.connect()parquery/__init__.py: Version bump to 2.0.7RELEASE_NOTES.md: Added 2.0.7 entryTest plan
DUCKDB_MEMORY_LIMIT=2GBenv var