Use json_schema_extra to add FilterSchema options to Field #1494
+21
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in vitalik#1335, Pydantic is restricting use of additional parameters to `Field`. See https://docs.pydantic.dev/2.9/migration/#changes-to-pydanticfield for more details. Move `q` and `ignore_none` into `json_extra_schema` as dictionary arguments. Also, `Query(...)` does not get along with type checkers so refresh to use the v1 `Query[]` style to be consistent.
|
FYI I have submitted a PR which attempts to solve this issue among other things: #1514 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #1335, Pydantic is restricting use of additional parameters to
Field. See https://docs.pydantic.dev/2.9/migration/#changes-to-pydanticfield for more details.Move
qandignore_noneintojson_extra_schemaas dictionary arguments.Also,
Query(...)does not get along with type checkers so refresh to use the v1Query[]style to be consistent.