feat(vite): cache rpc response #128
Draft
+94
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-devtools ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
webfansplz
force-pushed
the
feat/cache-data
branch
from
9f38406 to
009dbbd
Compare
commit: |
Member
|
We might want to do that inside getDevToolsRpcClient and also provide a API to invalidate the cache |
webfansplz
force-pushed
the
feat/cache-data
branch
from
882c507 to
f2829ae
Compare
webfansplz
force-pushed
the
feat/cache-data
branch
from
f2829ae to
d91a348
Compare
Member
Author
Done! |
webfansplz
commented
Nov 15, 2025
| functions: string[] | ||
| } | ||
|
|
||
| // @TODO: should be moved to birpc-x? |
Member
Author
There was a problem hiding this comment.
need to discussion.
webfansplz
commented
Nov 15, 2025
|
|
||
| const functions = await rpc.value.$call('vite:core:list-rpc-functions') | ||
|
|
||
| // TODO: add cacheable option to birpc-x and use it here |
Member
Author
|
Hi @antfu, I have refactored it, and I will send a PR to birpc if this solution is ok. |
webfansplz
force-pushed
the
feat/cache-data
branch
from
9d6b898 to
d025a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cache rpc response for Vite DevTools.