Merged
Conversation
Member
|
Thanks! It indeed looks better, but I am not sure if using a modal in a modal is a good design. I actually wish to have this more like a canvas to have more horizontal space, and the diff could be open at the position of the current node. |
Contributor
Author
|
Ok. This looks like a difficult design solution. I'll think about it. If I did it, I will open a new PR. and I will keep this PR. |
Member
|
Let's have it first. I do love your visual design! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this diff view looks very crowded on my screen. I tried to add a resizing feature.
Since the
ModuleFlow.vuewas getting quite large, I split the code intoModuleFlowDetails.vueandModuleFlowTimeline.vuebased on the left and right panel layout. This makes it easier for me to work on the styles and helps with future maintainability.The diff may look big, but there are no actual UI changes — sorry for the noise, and thanks for your understanding!
Demo:
CleanShot.2025-07-24.at.17.49.13.mp4