Skip to content

Comments

fix:Reset moduleDetailsViewType#54

Closed
CoutinhoTTS wants to merge 1 commit intovitejs:mainfrom
CoutinhoTTS:fix-Reset-moduleDetailsViewType
Closed

fix:Reset moduleDetailsViewType#54
CoutinhoTTS wants to merge 1 commit intovitejs:mainfrom
CoutinhoTTS:fix-Reset-moduleDetailsViewType

Conversation

@CoutinhoTTS
Copy link
Contributor

@CoutinhoTTS CoutinhoTTS commented Jul 24, 2025

The moduleDetailsViewType retains its last value. Upon re-entering the ModuleDetailsLoader component, this value is reset.

@webfansplz
Copy link
Member

webfansplz commented Jul 24, 2025

Be related to #48. It's somewhat by design, but reset seems reasonable as well. @antfu WDYT?

@antfu
Copy link
Member

antfu commented Jul 24, 2025

Why reseting?

@webfansplz
Copy link
Member

Just from my personal operating habits, resetting seems reasonable as well. But saving it was originally by design, so let's keep it this way!

@webfansplz webfansplz closed this Jul 24, 2025
@CoutinhoTTS CoutinhoTTS deleted the fix-Reset-moduleDetailsViewType branch August 6, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants