Skip to content

feat: enable HMR by default on ModuleRunner side #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: enable HMR by default on ModuleRunner side #1751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions guide/api-environment-runtimes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,15 +190,10 @@ export interface ModuleRunnerOptions {
| InterceptorOptions
/**
* HMR を無効にするか、HMR オプションを設定します。
*
* @default true
*/
hmr?:
| false
| {
/**
* HMR ロガーを設定します。
*/
logger?: false | HMRLogger
}
hmr?: boolean | ModuleRunnerHmr
/**
* カスタムモジュールキャッシュ。指定されていない場合は、モジュールランナーの
* インスタンスごとに個別のモジュールキャッシュが作成されます。
Expand Down Expand Up @@ -356,6 +351,7 @@ export const runner = new ModuleRunner(
return response.json()
},
},
hmr: false, // HMR は transport.connect を必要とするため HMR を無効にする
},
new ESModulesEvaluator(),
)
Expand Down