feat(types): type hints for hmr events #1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitejs-docs-ja ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jay-es
reviewed
Mar 19, 2025
Collaborator
jay-es
left a comment
jay-es
left a comment
There was a problem hiding this comment.
ありがとうございます！
内容は OK ですが CI がエラーになってしまっているので、念のため再プッシュお願いします 🙇
Contributor
Author
|
エラーを詳しく見てみたところ、どうやら元のcommitで追加された新しい型を使おうとしてしまっているのが原因のようでした。現時点では https://github.com/vitejs/vite の |
Collaborator
|
@shuuji3 承知しました！ |
Collaborator
|
@shuuji3 Vite のバージョン上げたので、お手すきの際に更新お願いします 🙏 |
Contributor
Author
|
preview: https://deploy-preview-1886--vitejs-docs-ja.netlify.app/guide/api-hmr.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1885
vitejs/vite@95424b2 の反映です。