Skip to content

fix: disable refresh for non-jsx without react import #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: disable refresh for non-jsx without react import #318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion packages/vite/src/node/plugins/oxc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,9 +327,17 @@ export function oxcPlugin(config: ResolvedConfig): Plugin {
? createFilter(jsxRefreshInclude, jsxRefreshExclude)
: undefined

const jsxImportSource =
(typeof oxcTransformOptions.jsx === 'object' &&
oxcTransformOptions.jsx.importSource) ||
'react'
const jsxImportRuntime = `${jsxImportSource}/jsx-runtime`
const jsxImportDevRuntime = `${jsxImportSource}/jsx-dev-runtime`

const getModifiedOxcTransformOptions = (
oxcTransformOptions: OxcTransformOptions,
id: string,
code: string,
environment: Environment,
): OxcTransformOptions => {
const result: OxcTransformOptions = {
Expand All @@ -339,11 +347,22 @@ export function oxcPlugin(config: ResolvedConfig): Plugin {
}

const jsxOptions = result.jsx

// disable refresh based by the same condition as @vitejs/plugin-react
// https://github.com/vitejs/vite-plugin-react/blob/c8ecad052001b6fc42e508f18433e6b305bca641/packages/plugin-react/src/index.ts#L261-L269
const [filepath] = id.split('?')
const isJSX = filepath.endsWith('x')

if (
typeof jsxOptions === 'object' &&
jsxOptions.refresh &&
(environment.config.consumer === 'server' ||
(jsxRefreshFilter && !jsxRefreshFilter(id)))
(jsxRefreshFilter && !jsxRefreshFilter(id)) ||
!(
isJSX ||
code.includes(jsxImportRuntime) ||
code.includes(jsxImportDevRuntime)
))
) {
result.jsx = { ...jsxOptions, refresh: false }
}
Expand Down Expand Up @@ -380,6 +399,7 @@ export function oxcPlugin(config: ResolvedConfig): Plugin {
const modifiedOxcTransformOptions = getModifiedOxcTransformOptions(
oxcTransformOptions,
id,
code,
this.environment,
)
const result = await transformWithOxc(
Expand Down