Skip to content

feat(plugin-react): make tests pass with plugin-react-oxc #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 1 commit into from
Apr 10, 2025
Merged

feat(plugin-react): make tests pass with plugin-react-oxc #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/vite-plugin-react.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@ export async function test(options: RunOptions) {
build: 'build',
beforeTest: 'pnpm playwright install chromium',
test: ['test', 'typecheck'],
overrides: {
'@vitejs/plugin-react-oxc>vite': 'catalog:rolldown-vite',
},
})
}
8 changes: 7 additions & 1 deletion utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,12 +522,18 @@ export async function applyPackageOverrides(
await overridePackageManagerVersion(pkg, pm)

if (pm === 'pnpm') {
const overridesWithoutSpecialSyntax = Object.fromEntries(
Object.entries(overrides)
//eslint-disable-next-line @typescript-eslint/no-unused-vars
.filter(([key, value]) => (value as string).includes('>')),
)

if (!pkg.devDependencies) {
pkg.devDependencies = {}
}
pkg.devDependencies = {
...pkg.devDependencies,
...overrides, // overrides must be present in devDependencies or dependencies otherwise they may not work
...overridesWithoutSpecialSyntax, // overrides must be present in devDependencies or dependencies otherwise they may not work
}
if (!pkg.pnpm) {
pkg.pnpm = {}
Expand Down