Skip to content

fix(rsc): add ?direct to get actual CSS content in dev mode instead of JS module #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
schiller-manuel wants to merge 4 commits into from
+9 −2
Closed

fix(rsc): add ?direct to get actual CSS content in dev mode instead of JS module #1044

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
314f6c0
fix: Add ?direct to get actual CSS content in dev mode instead of JS …
schiller-manuel Jan 10, 2026
3304e2b
Merge branch 'main' into rsc-css-dev
hi-ogawa Jan 13, 2026
c86e713
fix: prune ?direct css
hi-ogawa Jan 13, 2026
ba9a526
Merge branch 'main' into rsc-css-dev
hi-ogawa Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/plugin-rsc/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,8 +1147,12 @@ import.meta.hot.on("rsc:update", () => {
const nodes = document.querySelectorAll<HTMLLinkElement>(
"link[rel='stylesheet']",
)
// normalize paths with ?direct suffix for comparison
// TODO: we also have SSR CSS without ?direct
// TODO: test virtual css?
const prunePaths = e.paths.flatMap((p) => [p, p + '?direct'])
nodes.forEach((node) => {
if (e.paths.includes(node.dataset.rscCssHref!)) {
if (prunePaths.includes(node.dataset.rscCssHref!)) {
node.remove()
}
})
Expand Down Expand Up @@ -2260,7 +2264,10 @@ function vitePluginRscCss(
for (const file of [importer, ...result.visitedFiles]) {
this.addWatchFile(file)
}
const cssHrefs = result.hrefs.map((href) => href.slice(1))
const cssHrefs = result.hrefs.map((href) => {
const url = href.slice(1)
return url.includes('?') ? url + '&direct' : url + '?direct'
})
const deps = assetsURLOfDeps({ css: cssHrefs, js: [] }, manager)
return generateResourcesCode(
serializeValueWithRuntime(deps),
Expand Down