test: rewrite playground/ssr-react without react-router
#398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
approved these changes
Dec 26, 2024
hi-ogawa
force-pushed
the
test-no-react-router
branch
from
f754641 to
ac144fb
Compare
Contributor
Author
|
Indeed, I realized this change is completely independent from #397 😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
on top of test: simplifyplayground/ssr-react#397Now that Remix/ReactRouter team has own examples and test cases with Vite integration, I don't think using
react-routerhere has much value and keeping it up-to-date is worth it. I rewrote it with DIY minimal routing.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).