refactor: extract common code in common package #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
reviewed
Apr 7, 2025
Member
ArnaudBarre
left a comment
ArnaudBarre
left a comment
There was a problem hiding this comment.
Thanks for this, this will make the new plugin so small !
Two notes for me:
- I don't think going for the preambleCode->getPreambleCode deprecation is worth the added benefit for us or users.
- I was happy without the
import.meta.hot && !inWebWorkercheck in SWC because for me this checks only hide bundling issues. I'm afraid that if one day we implement HMR on webworker, we will break people that use to bundle random things in their worker. But given that most users as Babel users, it make sense to align in this direction
ArnaudBarre
reviewed
Apr 7, 2025
Member
Author
That's true. I'll remove this change. |
Member
Author
|
I've updated 👍 |
ArnaudBarre
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts common code from plugin-react and plugin-react-swc into
packages/common. This package will be bundled to both plugins so the number of dependencies are still the same.Behavior changes in each commit (due to misalignment of between plugins):
Could not Fast Refresherror now points tohttps://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react-swc#consistent-components-exportsinstead ofhttps://github.com/vitejs/vite-plugin-react-swc#consistent-components-exportsinjectIntoGlobalHookare removed from the default export object. I treated properties other thaninjectIntoGlobalHookis a internal thing, but it may treated as a breaking change.window.__vite_plugin_react_preamble_installed__is removed. This should not change any behavior.[plugin-react]reverted in 8d56222viteReact.preambleCodeis deprecated andviteReact.getPreambleCodeis newly exposedimport.meta.hot && !inWebWorkercheck is added.See https://github.com/vitejs/vite-plugin-react/pull/11#discussion_r430879201was removed from the cannot detect preamble error as it was stale.