Skip to content

(test publishing @vitejs/plugin-rsc) #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 28 commits into from
Closed

(test publishing @vitejs/plugin-rsc) #523

wants to merge 28 commits into from

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jul 4, 2025

Description

Recreating #521 as non-fork branch.

Comment on lines +18 to +30
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
- run: corepack enable
- run: pnpm i
- run: pnpm build
- run: pnpm -C packages/plugin-rsc tsc
- run: pnpm -C packages/plugin-rsc test

test-e2e:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 1 month ago

To fix the issue, add a permissions block to the root of the workflow file. This block will apply to all jobs in the workflow unless overridden by job-specific permissions. Based on the workflow's operations, the minimal permissions required are contents: read. This ensures that the GITHUB_TOKEN has only read access to repository contents, reducing the risk of unintended write operations.

Suggested changeset 1
.github/workflows/ci-rsc.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/ci-rsc.yml b/.github/workflows/ci-rsc.yml
--- a/.github/workflows/ci-rsc.yml
+++ b/.github/workflows/ci-rsc.yml
@@ -1,2 +1,4 @@
 name: ci-rsc
+permissions:
+  contents: read
 "on":
EOF
@@ -1,2 +1,4 @@
name: ci-rsc
permissions:
contents: read
"on":
Copilot is powered by AI and may make mistakes. Always verify output.
Comment on lines +31 to +61
name: test-rsc (${{ matrix.os }} / ${{ matrix.browser }})
runs-on: ${{ matrix.os }}
strategy:
# TODO: shard?
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
browser: [chromium]
include:
- os: ubuntu-latest
browser: firefox
- os: macos-latest
browser: webkit
fail-fast: false
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 22
- run: corepack enable
- run: pnpm i
- run: pnpm build
- run: pnpm -C packages/plugin-rsc exec playwright install ${{ matrix.browser }}
- run: pnpm -C packages/plugin-rsc test-e2e-ci --project=${{ matrix.browser }}
env:
TEST_ISOLATED: true
- uses: actions/upload-artifact@v4
if: always()
with:
name: test-results-${{ matrix.os }}-${{ matrix.browser }}
path: |
packages/plugin-rsc/test-results

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Jul 4, 2025

Alpha is released from this branch.
For the review and merge, I'll use an original PR #521, so closing this PR.

@hi-ogawa hi-ogawa closed this Jul 4, 2025
@hi-ogawa hi-ogawa deleted the feat-rsc-publish branch July 4, 2025 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant