Skip to content

test(rsc): fix flaky server restart test #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2025
Merged

test(rsc): fix flaky server restart test #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e7f00d
test(rsc): fix flaky server restart test
hi-ogawa Jul 6, 2025
38c1548
chore: cleanup
hi-ogawa Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 27 additions & 9 deletions packages/plugin-rsc/e2e/basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,33 @@ test.describe('dev-default', () => {
defineTest(f)
})

test.describe('dev-initial', () => {
const f = useFixture({ root: 'examples/basic', mode: 'dev' })

// verify css is collected properly on server startup (i.e. empty module graph)
testNoJs('style', async ({ page }) => {
await page.goto(f.url('./'))
await expect(page.locator('.test-style-client')).toHaveCSS(
'color',
'rgb(255, 165, 0)',
)
await expect(page.locator('.test-style-server')).toHaveCSS(
'color',
'rgb(255, 165, 0)',
)
await expect(page.locator('.test-tw-client')).toHaveCSS(
'color',
// blue-500
'rgb(0, 0, 255)',
)
await expect(page.locator('.test-tw-server')).toHaveCSS(
'color',
// red-500
'rgb(255, 0, 0)',
)
})
})

test.describe('build-default', () => {
const f = useFixture({ root: 'examples/basic', mode: 'build' })
defineTest(f)
Expand Down Expand Up @@ -656,15 +683,6 @@ function defineTest(f: Fixture) {
'rgb(255, 0, 0)',
)
})

testNoJs('no FOUC after server restart @nojs', async ({ page }) => {
const res = await page.request.get(f.url('/__test_restart'))
expect(await res.text()).toBe('ok')
await new Promise((r) => setTimeout(r, 100))
await page.goto(f.url('./'))
await testCss(page)
await testTailwind(page)
})
})

test('temporary references @js', async ({ page }) => {
Expand Down
17 changes: 0 additions & 17 deletions packages/plugin-rsc/examples/basic/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,23 +45,6 @@ export default defineConfig({
}),
// avoid ecosystem CI fail due to vite-plugin-inspect compatibility
!process.env.ECOSYSTEM_CI && inspect(),
{
// test server restart scenario on e2e
name: 'test-api',
configureServer(server) {
server.middlewares.use((req, res, next) => {
const url = new URL(req.url!, 'http://localhost')
if (url.pathname === '/__test_restart') {
setTimeout(() => {
server.restart()
}, 10)
res.end('ok')
return
}
next()
})
},
},
{
name: 'test-client-reference-tree-shaking',
enforce: 'post',
Expand Down
Loading