Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jul 12, 2025

Description

__vite_rsc_assets_manifest.js shouldn't be import-ed during the test since the module will be cached inside playwright worker but the content can change between different test variants (e.g. build-default and build-cloudflare). This was making rolldown run to fail on first run (then retry always succeeds since playwright recreate a worker) https://github.com/vitejs/vite-plugin-react/actions/runs/16235033401/job/45843973297#step:9:681

I already did this for basic.test.ts

const manifest = JSON.parse(
readFileSync(
f.root + '/dist/ssr/__vite_rsc_assets_manifest.js',
'utf-8',
).slice('export default '.length),
)
, but react-router.test.ts still had the old one.

@hi-ogawa hi-ogawa marked this pull request as ready for review July 12, 2025 06:38
@hi-ogawa hi-ogawa merged commit b1d63a8 into main Jul 12, 2025
20 checks passed
@hi-ogawa hi-ogawa deleted the 07-12-test_rsc_fix_ssr_modulepreload_link_test branch July 12, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants