-
-
Notifications
You must be signed in to change notification settings - Fork 168
Fix CSS import queries (?url, ?inline, ?raw) being incorrectly collected in RSC plugin #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
packages/plugin-rsc/examples/basic/src/routes/css-queries/client.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
'use client' | ||
|
||
import './test.css' // Normal CSS import - should be collected for SSR | ||
import cssUrl from './test.css?url' // URL query - should NOT be collected | ||
import cssInline from './test.css?inline' // Inline query - should NOT be collected | ||
import cssRaw from './test.css?raw' // Raw query - should NOT be collected | ||
|
||
export function TestCssQueries() { | ||
return ( | ||
<div data-testid="css-queries-component"> | ||
<div className="test-css-query-normal" data-testid="css-normal"> | ||
Normal CSS import (should have styles in SSR) | ||
</div> | ||
<div data-testid="css-url-value">CSS URL value: {cssUrl}</div> | ||
<div data-testid="css-inline-content"> | ||
CSS inline content length: {cssInline.length} | ||
</div> | ||
<div data-testid="css-raw-content"> | ||
CSS raw content length: {cssRaw.length} | ||
</div> | ||
</div> | ||
) | ||
} |
19 changes: 19 additions & 0 deletions
19
packages/plugin-rsc/examples/basic/src/routes/css-queries/test.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
.test-css-query-normal { | ||
color: rgb(75, 85, 99); /* gray-600 */ | ||
font-weight: bold; | ||
} | ||
|
||
.test-css-query-url { | ||
color: rgb(220, 38, 127); /* pink-600 */ | ||
text-decoration: underline; | ||
} | ||
|
||
.test-css-query-inline { | ||
color: rgb(101, 163, 13); /* lime-600 */ | ||
font-style: italic; | ||
} | ||
|
||
.test-css-query-raw { | ||
color: rgb(147, 51, 234); /* purple-600 */ | ||
text-transform: uppercase; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test for server component too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added server component test! Created
TestCssQueriesServer
component inserver.tsx
that tests the same CSS import scenarios as the client component. Also updated the e2e tests to verify both client and server component behavior. (8e97c2b)