Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jul 22, 2025

Description

Related

Currently rsc plugin automatically noExternal-ize dependencies with react in peerDependencies (i.e. 3rd party react package) to ensure all react import goes through Vite transform pipelines. This can be extended to support higher level framework such as waku, which has its own ecosystem package waku-jotai and we want to allow automatically noExternalizing them in the same way.

TODO

  • test (just trivial one)
  • doc (just jsdoc)

@hi-ogawa hi-ogawa added the trigger: preview Trigger pkg.pr.new label Jul 22, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 22, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-react@608
npm i https://pkg.pr.new/@vitejs/plugin-react-oxc@608
npm i https://pkg.pr.new/@vitejs/plugin-rsc@608
npm i https://pkg.pr.new/@vitejs/plugin-react-swc@608

commit: 5f87b8c

@hi-ogawa hi-ogawa changed the title feat(rsc): add frameworkPackages options to control server external feat(rsc): add frameworkPackages option to control server external Jul 22, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review July 22, 2025 06:13
@hi-ogawa hi-ogawa marked this pull request as draft July 22, 2025 06:46
@hi-ogawa
Copy link
Contributor Author

Oh wait. Probably waku-jotai should have react in peerDependencies since they are used internally.

@hi-ogawa
Copy link
Contributor Author

It's resolved on waku-jotai side wakujs/waku-jotai#1
Maybe this is for another day. Closing.

@hi-ogawa hi-ogawa closed this Jul 22, 2025
@hi-ogawa hi-ogawa deleted the 07-22-feat_rsc_add_frameworkpackages_options_to_control_server_external branch July 22, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trigger: preview Trigger pkg.pr.new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants