Skip to content

fix(react): use development jsx transform for NODE_ENV=development build #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025
Merged

fix(react): use development jsx transform for NODE_ENV=development build #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c46c36d
fix(react): use development jsx transform for `NODE_ENV=development` …
sapphi-red Jul 28, 2025
7c8096e
chore: remove unused var
sapphi-red Jul 28, 2025
c9ab02e
chore: add changelog
sapphi-red Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/plugin-react/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ When used with rolldown-vite, this plugin now uses Oxc for react refresh transfo

Since this behavior is what `@vitejs/plugin-react-oxc` did, `@vitejs/plugin-react-oxc` is now deprecated and the `disableOxcRecommendation` option is removed.

Also, while `@vitejs/plugin-react-oxc` used the production JSX transform even for `NODE_ENV=development` build, `@vitejs/plugin-react` uses the development JSX transform for `NODE_ENV=development` build.

### Allow processing files in `node_modules`

The default value of `exclude` options is now `[/\/node_modules\//]` to allow processing files in `node_modules` directory. It was previously `[]` and files in `node_modules` was always excluded regardless of the value of `exclude` option.
Expand Down
1 change: 0 additions & 1 deletion packages/plugin-react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ export default function viteReact(opts: Options = {}): Plugin[] {
runtime: 'automatic',
importSource: jsxImportSource,
refresh: command === 'serve',
development: command === 'serve',
},
jsxRefreshInclude: include,
jsxRefreshExclude: exclude,
Expand Down
5 changes: 0 additions & 5 deletions packages/plugin-rsc/e2e/starter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { expect, test } from '@playwright/test'
import { useFixture } from './fixture'
import { defineStarterTest } from './starter'
import { waitForHydration } from './helper'
import * as vite from 'vite'

test.describe('dev-default', () => {
const f = useFixture({ root: 'examples/starter', mode: 'dev' })
Expand All @@ -25,8 +24,6 @@ test.describe('build-cloudflare', () => {
})

test.describe('dev-production', () => {
test.skip('rolldownVersion' in vite)

const f = useFixture({
root: 'examples/starter',
mode: 'dev',
Expand All @@ -45,8 +42,6 @@ test.describe('dev-production', () => {
})

test.describe('build-development', () => {
test.skip('rolldownVersion' in vite)

const f = useFixture({
root: 'examples/starter',
mode: 'build',
Expand Down
2 changes: 1 addition & 1 deletion playground/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"include": ["*.ts", "**/__tests__/*.ts", "**/vite.config.ts"],
"include": ["*.ts", "**/__tests__/**/*", "**/vite.config.ts"],
"exclude": ["**/dist/**"],
"compilerOptions": {
"target": "ES2023",
Expand Down
Loading