fix(rsc): avoid unnecessary server hmr due to tailwind module deps #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
hi-ogawa
added a commit
to hi-ogawa/waku
that referenced
this pull request
Aug 1, 2025
hi-ogawa
deleted the
08-01-fix_rsc_avoid_unnecessary_server_hmr_due_to_tailwind_module_deps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed a redundant server hmr on Waku example where it uses tailwind and typegen. Any change causes an auto-generated type files
pages.gen.tsto be updated and it's doubly causing server hmr refetch.This won't be necessary after vitejs/vite#20391 (7.1.0-beta.1), but a workaround on rsc plugin side is fairly simple, so let's include this for now.
Also we didn't have tests to verify there's no redundant server hmr. Let's add such tests.