Skip to content

refactor(rsc): move writeManifest inside buildApp hook #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 1, 2025
Merged

refactor(rsc): move writeManifest inside buildApp hook #659

merged 5 commits into from
Aug 1, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Aug 1, 2025 •
edited
Loading

Description

I remembered this logic is quite a mess. Let's clean it up before releasing useBuildAppHook.

TODO

  • Test on Waku

@hi-ogawa hi-ogawa marked this pull request as ready for review August 1, 2025 05:09
@hi-ogawa hi-ogawa added the trigger: preview Trigger pkg.pr.new label Aug 1, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 1, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-react@659

npm i https://pkg.pr.new/@vitejs/plugin-react-oxc@659

npm i https://pkg.pr.new/@vitejs/plugin-rsc@659

npm i https://pkg.pr.new/@vitejs/plugin-react-swc@659

commit: e04c1e0

@hi-ogawa hi-ogawa merged commit a34f8c5 into main Aug 1, 2025
22 checks passed
@hi-ogawa hi-ogawa deleted the 08-01-refactor_rsc_move_writemanifest_inside_buildapp_hook branch August 1, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

trigger: preview Trigger pkg.pr.new

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hi-ogawa