fix(rsc): optimize use-sync-external-store
#674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
hi-ogawa
changed the title
use-sync-external-storeuse-sync-external-store
This was referenced Aug 5, 2025
hi-ogawa
deleted the
08-04-fix_rsc_vendor_and_optimize_use-sync-external-store_
branch
dai-shi
pushed a commit
to wakujs/waku
that referenced
this pull request
Aug 6, 2025
- Using vitejs/vite-plugin-react#674 I'm thinking to add a slight hack on plugin side to support `use-sync-external-store` out-of-the-box, which tends to be smuggled within deep dependency tree and causes a cryptic error. After this change, `e2e/fixtures/ssr-swr/waku.config.ts` can be removed. I thought this would just work without change on Waku, but it failed because it matches `@vitejs/plugin-rsc/` instead of `@vitejs/plugin-rsc`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
optimizeDeps.includeheuristics to ensure popular cjs packages to be automatically optimized #610This is like a more hacky territory, but I think this use case is worth saving to reduce minor paper cut as much as possible.
Actually we might not need to vendor as a copy, but simply optimizing
@vitejs/plugin-rsc > use-sync-external-store/**/*might be enough since Vite cannot differentiate where the dep comes from.