Skip to content

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Aug 4, 2025

Description

For example, this is used by tanstack https://github.com/TanStack/router/blob/8efac91d6d7d3e12ed5ef1964392241142492f6a/packages/react-router/src/ssr/renderRouterToStream.tsx#L2.

I remember one annoying thing about React node build is that it includes node builtin without node:... prefix, so it can ends up optimizing with node polyfill package, which then actually breaks code e.g. util not implementing TextEncoder properly https://github.com/browserify/node-util. But I think it's fine it only happens when users installs util in their own node_modules.

@hi-ogawa hi-ogawa marked this pull request as ready for review August 5, 2025 00:21
@hi-ogawa hi-ogawa added the trigger: preview Trigger pkg.pr.new label Aug 5, 2025
Copy link

pkg-pr-new bot commented Aug 5, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vitejs/plugin-react@675
npm i https://pkg.pr.new/@vitejs/plugin-react-oxc@675
npm i https://pkg.pr.new/@vitejs/plugin-rsc@675
npm i https://pkg.pr.new/@vitejs/plugin-react-swc@675

commit: fd27d6e

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Aug 5, 2025

@hi-ogawa hi-ogawa marked this pull request as draft August 5, 2025 01:48
@hi-ogawa hi-ogawa closed this in #687 Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trigger: preview Trigger pkg.pr.new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant