Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 4, 2025

Previously, the entire packages/plugin-rsc/** directory was completely ignored by ESLint. This PR enables only import sorting related rules for the plugin-rsc directory while keeping other ESLint rules disabled.

Changes Made

  1. Removed global ignore: Removed packages/plugin-rsc/** from the global ignores array in eslint.config.js

  2. Added targeted configuration: Added a new ESLint configuration section specifically for packages/plugin-rsc/** files that:

    • Disables all existing ESLint rules (TypeScript, Node.js, regexp, etc.)
    • Enables only the three import sorting related rules:
      • import-x/no-duplicates: Prevents duplicate imports
      • import-x/order: Enforces import order (built-ins, externals, internals)
      • sort-imports: Sorts import members alphabetically
  3. Applied auto-fixes: Ran ESLint auto-fix to resolve 27 import sorting violations across the plugin-rsc codebase

Example of fixes applied

Before:

import { test, expect } from '@playwright/test'
import { setupInlineFixture, useFixture } from './fixture'
import { x } from 'tinyexec'

After:

import { expect, test } from '@playwright/test'
import { x } from 'tinyexec'
import { setupInlineFixture, useFixture } from './fixture'

This ensures consistent import organization in the plugin-rsc codebase while avoiding the overhead of running all ESLint rules on this experimental package.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI changed the title [WIP] see eslint.config.js. currently packages/plugin-rsc/** is ignored entirely. enable only import sorting related rules. Enable import sorting ESLint rules for plugin-rsc directory Aug 4, 2025
@Copilot Copilot AI requested a review from hi-ogawa August 4, 2025 19:29
Copilot finished work on behalf of hi-ogawa August 4, 2025 19:30
@hi-ogawa hi-ogawa closed this Aug 4, 2025
@hi-ogawa hi-ogawa deleted the copilot/fix-3452598f-77c4-4a80-9eab-418909c1801d branch August 4, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants