Skip to content

fix(rsc): inject __vite_rsc_importer_resources import only once #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2025
Merged

fix(rsc): inject __vite_rsc_importer_resources import only once #742

merged 2 commits into from
Aug 20, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Aug 20, 2025 •
edited
Loading

Description

Previously each import.meta.viteRsc.loadCss() adds import __vite_rsc_importer_resources_xxx from "..." and it causes a name crash when they are added multiple times (either manually or due to auto loadCss injection). For example:

✗ Build failed in 32ms
error during build:
src/root.tsx (10:6): Identifier "__vite_rsc_importer_resources_366c10439797" has already been declared
file: /home/hiroshi/code/others/vite-plugin-react/packages/plugin-rsc/examples/starter/src/root.tsx:10:6

 8:   return (
 9:     <html lang="en">
10:       <head>
          ^
11:         <meta charSet="UTF-8" />
12:         <link rel="icon" type="image/svg+xml" href="/vite.svg" />

@hi-ogawa hi-ogawa marked this pull request as ready for review August 20, 2025 00:35
@hi-ogawa hi-ogawa merged commit 5b28ba5 into main Aug 20, 2025
22 checks passed
@hi-ogawa hi-ogawa deleted the 08-20-fix_rsc_inject___vite_rsc_importer_resources_import_only_once branch August 20, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hi-ogawa