Skip to content

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Aug 21, 2025

Description

TODO

  • server -> client
    • this triggers "server hmr" and it naturally pulls in new client component via new render
  • client -> server
    • this change is currently detected as "client hmr". this needs to trigger server hmr instead.

For "use server", it shouldn't cause any issues since the state is only for build, but it would be still nice to synchronize properly. This should be done after we also align the state for "use server" and "use client" like hi-ogawa/vite-plugins#880

@hi-ogawa hi-ogawa changed the title fix(rsc): handle added/removed directive during dev fix(rsc): handle added/removed "use client" during dev Aug 21, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review August 21, 2025 08:23
@hi-ogawa hi-ogawa merged commit 232be7b into main Aug 21, 2025
24 checks passed
@hi-ogawa hi-ogawa deleted the 08-21-fix_rsc_handle_added_removed_directive_during_dev branch August 21, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant