fix(rsc): replace 'rolldownVersion' in this.meta with 'rolldownVersion' in vite for Vite 6 compat
#761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: hi-ogawa <[email protected]>
Copilot
AI
changed the title
"rolldownVersion" in this.meta with const isRolldownVite = 'rolldownVersion' in vite like in packages/plugin-react/src/index.ts"rolldownVersion" in this.meta with 'rolldownVersion' in vite pattern
Copilot finished work on behalf of
hi-ogawa
August 22, 2025 23:16
Co-authored-by: hi-ogawa <[email protected]>
Copilot
AI
changed the title
"rolldownVersion" in this.meta with 'rolldownVersion' in vite pattern'rolldownVersion' in this.meta with 'rolldownVersion' in vite pattern in plugin-rsc
Copilot finished work on behalf of
hi-ogawa
August 22, 2025 23:24
hi-ogawa
changed the title
'rolldownVersion' in this.meta with 'rolldownVersion' in vite pattern in plugin-rsc'rolldownVersion' in this.meta with 'rolldownVersion' in vite for Vite 6 compat
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #760 by updating the rolldown detection pattern in
@vitejs/plugin-rscto match the standard approach used in@vitejs/plugin-react.Problem
The
@vitejs/plugin-rscplugin was using an inconsistent pattern to detect rolldown-vite:'rolldownVersion' in this.metainstead of the standard patternThis is inconsistent with the correct approach used in
@vitejs/plugin-react, which imports the vite module and checks for therolldownVersionproperty directly.Solution
Updated the plugin to follow the same pattern as
@vitejs/plugin-react:import * as vite from 'vite''rolldownVersion' in this.metato'rolldownVersion' in viteBenefits
this.meta) availabilityThe changes are minimal and surgical, only updating the rolldown detection logic without affecting any other functionality.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.