Skip to content

fix(rsc): replace 'rolldownVersion' in this.meta with 'rolldownVersion' in vite for Vite 6 compat #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2025
Merged

fix(rsc): replace 'rolldownVersion' in this.meta with 'rolldownVersion' in vite for Vite 6 compat #761

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
607b103
Initial plan
Copilot Aug 22, 2025
5ff7204
Fix rolldownVersion detection pattern in plugin-react-oxc and plugin-rsc
Copilot Aug 22, 2025
9133654
revert: restore original rolldown detection in plugin-react-oxc
Copilot Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/plugin-react-oxc/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { dirname, join } from 'node:path'
import { fileURLToPath } from 'node:url'
import { readFileSync } from 'node:fs'
import * as vite from 'vite'
import type { BuildOptions, Plugin } from 'vite'
import {
addRefreshWrapper,
Expand Down Expand Up @@ -35,6 +36,8 @@ export default function viteReact(opts: Options = {}): Plugin[] {
const jsxImportRuntime = `${jsxImportSource}/jsx-runtime`
const jsxImportDevRuntime = `${jsxImportSource}/jsx-dev-runtime`

const isRolldownVite = 'rolldownVersion' in vite

const viteConfig: Plugin = {
name: 'vite:react-oxc:config',
config(userConfig, { command }) {
Expand Down Expand Up @@ -70,7 +73,7 @@ export default function viteReact(opts: Options = {}): Plugin[] {
)
},
options() {
if (!this.meta.rolldownVersion) {
if (!isRolldownVite) {
throw new Error(
'@vitejs/plugin-react-oxc requires rolldown-vite to be used. ' +
'See https://vitejs.dev/guide/rolldown for more details about rolldown-vite.',
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-rsc/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { pathToFileURL } from 'node:url'
import { createRequestListener } from '@remix-run/node-fetch-server'
import * as esModuleLexer from 'es-module-lexer'
import MagicString from 'magic-string'
import * as vite from 'vite'
import {
type BuilderOptions,
type DevEnvironment,
Expand Down Expand Up @@ -1269,7 +1270,7 @@ function customOptimizerMetadataPlugin({
environments: {
client: {
optimizeDeps:
'rolldownVersion' in this.meta
'rolldownVersion' in vite
? ({
rolldownOptions: {
plugins: [optimizerPluginRolldown()],
Expand Down